<html>
<head><meta charset="utf-8"><title>test organization · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/test.20organization.html">test organization</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="165015674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/test%20organization/near/165015674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/test.20organization.html#165015674">(May 06 2019 at 20:22)</a>:</h4>
<p>I've created an issue to track the test refactorings: <a href="https://github.com/rust-lang/chalk/issues/224" target="_blank" title="https://github.com/rust-lang/chalk/issues/224">https://github.com/rust-lang/chalk/issues/224</a></p>



<a name="165050505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/test%20organization/near/165050505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/test.20organization.html#165050505">(May 07 2019 at 07:55)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> Types like <code>db::ChalkDatabase</code> and <code>query::LoweringDatabase</code> are used by both <code>chalki</code> and the tests, would it make sense to move these out to a new crate ("chalk-model"?), or would that be too much splitting?</p>



<a name="165071222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/test%20organization/near/165071222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/test.20organization.html#165071222">(May 07 2019 at 13:39)</a>:</h4>
<p>Mmm, I guess I could go either way. I think you could have a <code>chalk-integration</code> crate that has a bunch of <code>#[test]</code> tests, and a chalki uses that .. but I also think it'd be ok to pull the tests out into their own crates</p>



<a name="165107741"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/test%20organization/near/165107741" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/test.20organization.html#165107741">(May 07 2019 at 20:26)</a>:</h4>
<p>There were some problems with circular dependencies, so I ended up creating a <code>chalk-integration crate</code>, and <code>wf.rs</code> fit there better as well</p>



<a name="165881051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/test%20organization/near/165881051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/test.20organization.html#165881051">(May 17 2019 at 08:12)</a>:</h4>
<p>Hmm, now <code>chalk-tests</code> depends on <code>chalk-integration</code>, which depends on <code>chalk-solve</code> (which is the root crate)... So now the tests can't be moved to a <code>/tests</code> directory, since it'd be a dependency cycle then</p>



<a name="165921143"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/test%20organization/near/165921143" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/test.20organization.html#165921143">(May 17 2019 at 17:48)</a>:</h4>
<p>I think you can use a dev-dependency for this</p>



<a name="165921177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/test%20organization/near/165921177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/test.20organization.html#165921177">(May 17 2019 at 17:48)</a>:</h4>
<p>but maybe I am wrong?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>